Open
Conversation
ColdL
force-pushed
the
add-vector-type
branch
2 times, most recently
from
1f4ea3f to
c0ba527
Compare
ColdL
force-pushed
the
add-vector-type
branch
7 times, most recently
from
5559fd0 to
ca90ddd
Compare
JingsongLi
reviewed
Feb 3, 2026
| <td>Specify the vector store file format.</td> | ||
| </tr> | ||
| <tr> | ||
| <td><h5>vector-store.target-file-size</h5></td> |
| <td>Specify the vector store fields.</td> | ||
| </tr> | ||
| <tr> | ||
| <td><h5>vector-store.format</h5></td> |
| <td>The Variant shredding schema for writing.</td> | ||
| </tr> | ||
| <tr> | ||
| <td><h5>vector-store.fields</h5></td> |
| long firstRowId = compactBefore.get(0).nonNullFirstRowId(); | ||
|
|
||
| RowType readWriteType = | ||
| List<String> vectorStoreFieldNames = table.coreOptions().vectorStoreFieldNames(); |
Contributor
There was a problem hiding this comment.
Why here need to deal with vectorStoreFieldNames? If you take a look to blob-field, only engines need to handle it.
Contributor
|
Suggest splitting the PR to multiple PRs for quick advancement. |
ColdL
force-pushed
the
add-vector-type
branch
from
ca90ddd to
1fe9f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #7011
Tests
API and Format
Documentation