[core] Split blob-as-descriptor into read-blob-as-descriptor and write-blob-from-descriptor#7123
Open
Zouxxyy wants to merge 2 commits intoapache:masterfrom
Open
[core] Split blob-as-descriptor into read-blob-as-descriptor and write-blob-from-descriptor#7123Zouxxyy wants to merge 2 commits intoapache:masterfrom
blob-as-descriptor into read-blob-as-descriptor and write-blob-from-descriptor#7123Zouxxyy wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks for @Zouxxyy , can you add a fallback configuration to make the old table could work the this change? |
Contributor
Author
I should have added |
Contributor
|
We need to conduct more research. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
There are two main reasons for this change:
blob-as-descriptoris highly ambiguous during writes—it actually means that the input for writing is a descriptor, not that the blob itself is being written as a descriptor.A single configuration cannot adequately serve both use cases. I believe, the most common scenario should be:
write-blob-from-descriptor=trueso that data is loaded at write time which is extremely memory-efficient. This maybe can be set to default true, in fact, there has been discussion on this topic: [api] Set blob-as-descriptor default to true #7021read-blob-as-descriptor=falsesince in most read scenariosin some case, we need the original raw data rather than a descriptor.Tests
API and Format
Documentation