[spark] Support MergeInto on Paimon append-only table in spark V2 write#7200
Merged
YannByron merged 2 commits intoapache:masterfrom Feb 5, 2026
Merged
[spark] Support MergeInto on Paimon append-only table in spark V2 write#7200YannByron merged 2 commits intoapache:masterfrom
YannByron merged 2 commits intoapache:masterfrom
Conversation
b0f4f21 to
8d65750
Compare
YannByron
reviewed
Feb 4, 2026
|
|
||
| var dataSplits: Array[DataSplit] = Array() | ||
|
|
||
| private def loadAllSplits(): Unit = { |
Contributor
There was a problem hiding this comment.
Extract the initialization of snapshotReader from loadAllSplits and filter methods, treat it as a member variable, and then define dataSplits as a lazy variable. The filter method just applies SnapshotReader#withDataFileNameFilter if it's called.
Contributor
Author
There was a problem hiding this comment.
@YannByron SnapshotReader is not serializable, it cannot be declared as a member variable.
Contributor
|
+1, just left a comment. |
3fa6ccd to
e77106d
Compare
e77106d to
bb86973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Support MergeInto on Paimon append-only table in spark V2 write
Tests
CI