[core] BucketedAppendCompactManager should use compactionFileSize instead of targetFileSize#7217
Merged
JingsongLi merged 5 commits intoapache:masterfrom Feb 6, 2026
Merged
Conversation
added 3 commits
February 5, 2026 19:01
yuzelin
force-pushed
the
fix-compaction-size
branch
from
b4028e9 to
4331ecd
Compare
JingsongLi
requested changes
Feb 6, 2026
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Please add test for this.
JingsongLi
reviewed
Feb 6, 2026
| if (fileNum >= minFileNum) { | ||
| return Optional.of(candidates); | ||
| } else if (totalFileSize >= targetFileSize) { | ||
| } else if (totalFileSize >= compactionFileSize) { |
Contributor
There was a problem hiding this comment.
See AppendCompactCoordinator, there is another magic...
added 2 commits
February 6, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
See #1680
Tests
API and Format
Documentation