refresh XWPFChart.java cache from embedded values #974
refresh XWPFChart.java cache from embedded values #974emmanueldufour wants to merge 2 commits intoapache:trunkfrom
Conversation
Word keeps cached values that need be refreshed after the embedded workbook has been updated. This is just the first step refreshing categories and series labels (tested for bar charts). TODO ultimately a function should be provided to refresh the entire cache
|
Can you start with using descriptive names for both your PRs? |
emmanueldufour
changed the title
done |
|
It is against ASF licensing policies to use code from stackoverflow.com due to the restrictive licensing that they apply to code on the site. You need to get the people who wrote the code to place the code in the public domain or license it with a more permissive license. |
I did not use code from stackoverflow. I merely quoted related issues this is supposed to help with. |
| * Create a new chart in document | ||
| * | ||
| * @since 4.0.0 | ||
| * @since POI 4.0.0 |
There was a problem hiding this comment.
yes sorry I didnt intend to but Im struggling with GIT, if you could revert it that would help
There was a problem hiding this comment.
what can I revert in your PR?
There was a problem hiding this comment.
since 4.0.0 vs since POI 4.0.0
There was a problem hiding this comment.
I wasn't offering to do it. I was asking why I'm expected to do it.
| return wb.getSheet( cell.getSheetName()).getRow(cell.getRow()).getCell(cell.getCol()).toString(); | ||
|
|
||
| } | ||
| /** |
There was a problem hiding this comment.
whitespace between methods - no need for all the whitespace inside the method - please try to make the code follow the existing style in classes
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
- no tests
- code incorrectly formatted
found an existing function that performs most the the cache refreshing
2 participants
Word keeps cached values that need be refreshed after the embedded workbook has been updated. This is just the first step refreshing categories and series labels (tested for bar charts).
see for ex the related issues:
https://stackoverflow.com/questions/74703330/updated-excel-chart-in-word-document-not-getting-reflected-apache-poi
https://stackoverflow.com/questions/54681481/apache-poi-when-editing-chart-data-in-a-word-file-it-returns-to-the-data-defi
TODO ultimately a function should be provided to refresh the entire chart cache
TODO getWorkbookCells and getWorkbookCellVallue should be moved to XSSFWorkbook