[improve][misc] PIP-351: Add options to Pulsar-Test client to support KeyStore based TLS#22692
Open
shasank112001 wants to merge 16 commits intoapache:masterfrom
Open
[improve][misc] PIP-351: Add options to Pulsar-Test client to support KeyStore based TLS#22692shasank112001 wants to merge 16 commits intoapache:masterfrom
shasank112001 wants to merge 16 commits intoapache:masterfrom
Conversation
50c9886 to
d0d5384
Compare
nodece
requested changes
May 10, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceBaseArguments.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerfClientUtilsTest.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerformanceBaseArgumentsTest.java
Show resolved
Hide resolved
nodece
approved these changes
May 11, 2024
nodece
previously requested changes
May 11, 2024
Member
nodece
left a comment
There was a problem hiding this comment.
Please revert return String.format(Locale.US, format, get_FloatValue(size));.
47a92f6 to
09ef3f9
Compare
0a6839e to
9ddc238
Compare
9ddc238 to
8d34bf0
Compare
crossoverJie
approved these changes
Jun 7, 2024
lhotari
approved these changes
Jun 10, 2024
Member
|
PIP has been accepted and merged. https://lists.apache.org/thread/61l7bdhkjy0vy61934shmh2cphb6pp06 Good work @shasank112001 |
406e8fa to
8433bc8
Compare
Contributor
Author
…erformanceBaseArguments.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceBaseArgumentsTest.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
8433bc8 to
1191223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22678
Main Issue: #22678
PIP: #22694
Motivation
If you want to create a TestClient which uses AuthenticationKeyStoreTls as its authPlugin, Pulsar Test Admin/Client utilized in Pulsar-perf is unable to setup a vaild SSL context due to the requirement of the property "useKeyStoreTls" to be "true" for using keystores properly.
Moreover, utilizing the property "useKeyStoreTls" requires the use of trust-stores and not trust certificates, therefore requiring additional trustStoreType, trustStorePath and trustStorePass as parameters to be available, to utilize PulsarPerf.
Modifications
The following changes have been made:
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: PR