[fix] [broker] fix subscribe a non-existent cluster/namespace/topic.#22715
Open
thetumbled wants to merge 3 commits intoapache:masterfrom
Open
[fix] [broker] fix subscribe a non-existent cluster/namespace/topic.#22715thetumbled wants to merge 3 commits intoapache:masterfrom
thetumbled wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
PTAL, thanks. @lhotari @dao-jun @BewareMyPower @poorbarcode |
Technoboy-
reviewed
May 22, 2024
| return FutureUtil.failedFuture(e); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Seems no need try/catch
There was a problem hiding this comment.
Is it possible the same issue is present when the tenant does not exist as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the topic name is in the format of V1, we can subscribe a topic in non-existent cluster/namespace without any exception.
Modifications
Need to add check for such case.
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#51