[revert] "[improve][ml] Do not switch thread to execute asyncAddEntry's core logic (#23940)"

[BewareMyPower]

This reverts commit 215b36d.

Motivation

See some discussion details in #23983.

#23940 and #23983 (not merged) both change the semantic for ManagedLedgerInterceptor#beforeAddEntry:

• Before: it's called by the internal executor of the ManagedLedgerImpl
• After: it's called as a part of ManagedLedgerImpl#asyncAddEntry in the same thread.

Since managed ledger and the interceptor are both pluggable (the interceptor can be changed via configuring BrokerEntryMetadataInterceptor or even ManagedLedgerConfig#setManagedLedgerInterceptor), the semantic change should require a formal PIP. Before that, the downstream applications should only rely on specific implementation details and hack into ManagedLedgerImpl.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[BewareMyPower]

I reverted #23940 in branch-4.0

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (bbc6224) to head (0a2c20e).
Report is 921 commits behind head on master.

Files with missing lines	Patch %	Lines
...okkeeper/mledger/impl/ShadowManagedLedgerImpl.java	14.28%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23994      +/-   ##
============================================
+ Coverage     73.57%   74.24%   +0.66%     
+ Complexity    32624    31909     -715     
============================================
  Files          1877     1853      -24     
  Lines        139502   143865    +4363     
  Branches      15299    16348    +1049     
============================================
+ Hits         102638   106807    +4169     
+ Misses        28908    28670     -238     
- Partials       7956     8388     +432     

Flag	Coverage Δ
inttests	26.69% <22.22%> (+2.11%)	⬆️
systests	23.19% <22.22%> (-1.14%)	⬇️
unittests	73.77% <77.77%> (+0.92%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java	82.06% <100.00%> (+1.40%)	⬆️
...okkeeper/mledger/impl/ShadowManagedLedgerImpl.java	58.85% <14.28%> (+3.18%)	⬆️

... and 1047 files with indirect coverage changes

[lhotari]

cherry-pick commit in branch-4.0 is 6b46035