[fix][test] Fix MultiBrokerLeaderElectionExpirationTest Mockito spy usage#25425
Merged
lhotari merged 1 commit intoapache:masterfrom Mar 30, 2026
Merged
Conversation
Fix Mockito spy compatibility issue: when(spy).thenReturn() doesn't work correctly with Mockito spies on concrete classes. Use doReturn().when(spy) pattern instead. Also add proper generic cast with @SuppressWarnings for the MetadataCacheConfig builder.
merlimat
force-pushed
the
fix/flaky-MultiBrokerLeaderElectionExpirationTest
branch
from
9c27977 to
5e3be4c
Compare
lhotari
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix compilation/runtime issue in
MultiBrokerLeaderElectionExpirationTest.The test uses
when(spy.getDefaultMetadataCacheConfig()).thenReturn(...)which doesn't work correctly with Mockito spies on concrete classes — it actually invokes the real method during stubbing setup. Also, theMetadataCacheConfig.builder().build()returns a raw type that needs proper generic casting.Modifications
when(spy).thenReturn()todoReturn().when(spy)pattern for correct Mockito spy behavior@SuppressWarnings("unchecked")cast forMetadataCacheConfig<Object>import static org.mockito.Mockito.doReturnDocumentation
doc-not-neededMatching PR in forked repository
No response