[improve][test] Fix try-with-resources compile warnings in test code#25429
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[improve][test] Fix try-with-resources compile warnings in test code#25429merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
Suppress [try] warnings across test code: - Add @SuppressWarnings("try") for auto-closeable resources whose close() throws InterruptedException (PulsarSslFactory, BookKeeper, ZooKeeper, PulsarTestContext, etc.) - Rename unreferenced try-with-resources variables to 'ignored' - Add @SuppressWarnings("try") for intentionally unreferenced auto-closeable resources used for side effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix
trycompiler warnings in test code — auto-closeable resources that are not properly handled in try-with-resources statements.This is part of a series to clean up test compile warnings (following production code cleanup in #25414-#25422).
Changes
close()throwsInterruptedException— cannot be used in try-with-resources without catching checked exception; add@SuppressWarnings("try")at method levelignoredor suppress with@SuppressWarnings("try")Affected modules:
pulsar-broker,pulsar-broker-common,pulsar-common,pulsar-client,pulsar-functions,managed-ledger, and others (~28 files).Verifying this change
./gradlew compileTestJavapasses cleanlytrywarning count drops to zeroDoes this pull request potentially affect one of the following areas?
Documentation
doc-not-needed— test-only changes