[improve][test] Fix rawtypes compile warnings in test code#25430
Open
merlimat wants to merge 3 commits intoapache:masterfrom
Open
[improve][test] Fix rawtypes compile warnings in test code#25430merlimat wants to merge 3 commits intoapache:masterfrom
merlimat wants to merge 3 commits intoapache:masterfrom
Conversation
Add proper generic type parameters to raw types across test code: - ArrayList/HashSet/HashMap → diamond operator <> - Class → Class<?> - Producer/Consumer/Message/Schema → proper type params - ProducerBuilder/ConsumerBuilder/ReaderBuilder → <?> - Record/PulsarSink/MessageImpl → proper type params - CompletableFuture/Answer/BiConsumer → proper type params - Use method-level @SuppressWarnings("rawtypes") only where fixing would cascade into compile errors
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
dao-jun
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix
rawtypescompiler warnings in test code by adding proper generic type parameters to raw types.This is part of a series to clean up test compile warnings (following production code cleanup in #25414-#25422).
Changes
Class→Class<?>,Producer→Producer<?>,Consumer→Consumer<?>,Message→Message<?>,Schema→Schema<?>,List→List<?>, etc.<>where type can be inferred@SuppressWarnings("rawtypes")at method level only where fixing raw types would cascade into unchecked/type-erasure compile errors (e.g., TestNG DataProvider methods returningObject[][])Affects ~99 files across all modules.
Verifying this change
./gradlew compileTestJavapasses cleanlyrawtypeswarning count drops significantlyDoes this pull request potentially affect one of the following areas?
Documentation
doc-not-needed— test-only changes