[improve][test] Fix unchecked compile warnings in test code#25431
Merged
merlimat merged 5 commits intoapache:masterfrom Mar 31, 2026
Merged
[improve][test] Fix unchecked compile warnings in test code#25431merlimat merged 5 commits intoapache:masterfrom
merlimat merged 5 commits intoapache:masterfrom
Conversation
Fix unchecked warnings across test code: - Add @SuppressWarnings("unchecked") for Mockito mock casts and generic array creation (unavoidable in Java) - Convert when().thenReturn() to doReturn().when() for wildcard capture issues - Add type parameters to raw constructors and declarations - Add @SafeVarargs for varargs utility methods
lhotari
approved these changes
Mar 30, 2026
dao-jun
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix
uncheckedcompiler warnings in test code — unchecked casts and generic array creation due to type erasure.This is part of a series to clean up test compile warnings (following production code cleanup in #25414-#25422).
Changes
@SuppressWarnings("unchecked")at method or variable level for unavoidable Mockito mock casts (type erasure prevents parameterized mock casts at runtime)doReturn().when()instead ofwhen().thenReturn()where wildcard capture causes unchecked warnings@SafeVarargsfor varargs utility methods that only read from the arrayAffects ~213 files across all modules.
Verifying this change
./gradlew compileTestJavapasses cleanlyuncheckedwarning count drops to zeroDoes this pull request potentially affect one of the following areas?
Documentation
doc-not-needed— test-only changes