Skip to content

[SYNCOPE-1955] OIDC custom scope management #1320

Merged
ilgrosso merged 4 commits intoapache:4_1_Xfrom
ilgrosso:SYNCOPE-1955
Mar 13, 2026
Merged

[SYNCOPE-1955] OIDC custom scope management #1320
ilgrosso merged 4 commits intoapache:4_1_Xfrom
ilgrosso:SYNCOPE-1955

Conversation

@ilgrosso
Copy link
Member

No description provided.

@ilgrosso ilgrosso changed the title Syncope 1955 [SYNCOPE-1955] OIDC custom scope management Mar 13, 2026

private static final long serialVersionUID = -7283064059391373326L;

public class CustomScope implements EntityTO {

Check notice

Code scanning / CodeQL

Inner class could be static Note

CustomScope should be made static, since the enclosing instance is not used.

protected void buildForOIDCustomScope(
final OIDCRPClientAppTO clientApp,
final DefaultAttrReleasePolicyConf conf,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'conf' is never used.
clientApp, conf, policies, scope, internal, external.toString()),
() -> LOG.warn(
"OIDC client app {} defines custom claim {}={} for which no valid scope could be found",
clientApp, internal, external));

Check notice

Code scanning / CodeQL

Use of default toString() Note

Default toString(): OIDCRPClientAppTO inherits toString() from Object, and so is not suitable for printing.
@ilgrosso ilgrosso merged commit b66ea15 into apache:4_1_X Mar 13, 2026
0 of 25 checks passed
@ilgrosso ilgrosso deleted the SYNCOPE-1955 branch March 13, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant