Skip to content

fix: badges not visible on filter button#2840

Merged
HarshMN2345 merged 5 commits intomainfrom
fix-badges-not-visible-whether-filter-is-applied
Feb 6, 2026
Merged

fix: badges not visible on filter button#2840
HarshMN2345 merged 5 commits intomainfrom
fix-badges-not-visible-whether-filter-is-applied

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Feb 6, 2026

What does this PR do?

before:

image

after:

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • New Features

    • Filters button now displays a badge indicating the count of active filters when in dropdown mode.
  • Bug Fixes

    • Fixed filter tag state so the active-tag count reliably resets and reflects current filter changes, preventing stale badge values.

@appwrite
Copy link

appwrite bot commented Feb 6, 2026

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Failed Failed View Logs Preview URL QR Code

Tip

Realtime gives you live updates for users, storage, functions, and databases

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Warning

Rate limit exceeded

@HarshMN2345 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

The change adds parsedTags to the named imports in responsiveContainerHeader.svelte and uses it to conditionally render a badge prop on the Filters Button when filtersStyle === 'dropdown' and parsedTags is non-empty. The Button markup was reformatted across multiple lines. In setFilters.ts, parsedTags is now exported and is cleared (set to an empty array) at the start of setFilters before any per-filter processing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the issue being fixed: making badges visible on the filter button when filters are applied.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-badges-not-visible-whether-filter-is-applied

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: Darshan <itznotabug@gmail.com>
@HarshMN2345 HarshMN2345 merged commit 2550652 into main Feb 6, 2026
1 of 4 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-badges-not-visible-whether-filter-is-applied branch February 6, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants