Internalize NDDataTypeToScalar#569
Merged
MarkRivers merged 2 commits intoareaDetector:masterfrom Feb 18, 2026
Merged
Conversation
ScalarType enum values from pvDataCPP are a de-facto part of the NTNDArray definition. So internalize them to avoid an unnecessary cross dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #568 by using replacing the
pvData::ScalarTypeenum codes with constants. This avoids an unnecessary cross-dependency, and better reflects the reality that these values have become a de facto part of the NTNDArray on-the-wire definition.I have included an optional second commit adding a sanity bounds check of
NDDataTypeToScalar[].