Skip to content

adding cloud client#83

Merged
arun1729 merged 1 commit intomasterfrom
v3.8.0
Apr 13, 2026
Merged

adding cloud client#83
arun1729 merged 1 commit intomasterfrom
v3.8.0

Conversation

@arun1729
Copy link
Copy Markdown
Owner

@arun1729 arun1729 commented Apr 7, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 78.75458% with 174 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.89%. Comparing base (8053703) to head (f7f7328).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cog/embeddings.py 74.70% 65 Missing ⚠️
cog/cloud_client.py 76.21% 49 Missing ⚠️
cog/torque.py 77.72% 47 Missing ⚠️
cog/search.py 91.66% 10 Missing ⚠️
cog/view.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   87.41%   85.89%   -1.53%     
==========================================
  Files          13       16       +3     
  Lines        2480     2949     +469     
==========================================
+ Hits         2168     2533     +365     
- Misses        312      416     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a cloud mode for CogDB, allowing the library to operate as an authenticated HTTP client for CogDB Cloud. Key additions include a CloudClient for managing HTTP transport, query string serialization, and mutation batching. The Graph class in torque.py has been updated to toggle between local and cloud modes based on the presence of an API key. Feedback focuses on improving the robustness of the cloud implementation, specifically addressing a potential injection vulnerability in query string quoting and mitigating memory exhaustion risks when uploading large datasets via load_triples, load_csv, and put_batch by implementing client-side batching.

Comment thread cog/cloud_client.py Outdated
Comment thread cog/torque.py Outdated
Comment thread cog/torque.py Outdated
Comment thread cog/torque.py Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31dec062f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cog/torque.py Outdated
Comment thread cog/cloud_client.py
Comment thread cog/cloud_client.py
Comment thread cog/torque.py
@arun1729 arun1729 force-pushed the v3.8.0 branch 4 times, most recently from a57c026 to f92ec96 Compare April 13, 2026 15:03
@arun1729 arun1729 merged commit 3f63dd7 into master Apr 13, 2026
5 of 7 checks passed
@arun1729 arun1729 deleted the v3.8.0 branch April 13, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant