Conversation
Collaborator
|
Wow, guess we have to take a look at |
|
Hi! Great to see Pedalboard included here - thanks! One question though, you mention:
Not sure about this part; JUCE is statically linked into Pedalboard as a native library, and Pedalboard shouldn't require any external Python or native dependencies at runtime except for I also notice that Pedalboard's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in faroit/python_audio_loading_benchmark#21 this adds pedalboard to the benchmarks as it provides the possibility to read and access WAV, FLAC, OGG, and MP3 files since version 0.5.0. It comes bundled with JUCE and does need external libraries.
For WAV, FLAC, OGG performance is very similar to what the
libsndfilebased solutions achieve:For MP3 it is one of the fastest libraries for reading:
But where it really shines is accessing metadata (as this is not part of the benchmarking I have not tested if they are also correct):
/cc @psobot