add FSx CSI driver test to addon suite #796
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikash-s1
reviewed
Dec 19, 2025
| // Comment out the below code when the add-on is available publicly on aws console | ||
|
|
||
| // fsxCSITest, err := addonEc2Test.NewFsxCSIDriverTest(ctx) | ||
| fsxCSITest, err := addonEc2Test.NewFsxCSIDriverTest(ctx) |
Member
There was a problem hiding this comment.
Looks NewFsxCSIDriverTest called twice.
vikash-s1
reviewed
Dec 19, 2025
| // DeferCleanup(func(ctx context.Context) { | ||
| // Expect(fsxCSITest.Delete(ctx)).To(Succeed(), "should cleanup FSx CSI driver successfully") | ||
| // }) | ||
| DeferCleanup(func(ctx context.Context) { |
Member
There was a problem hiding this comment.
nit - ctx variable is looks reuse and can shadow the outer ctx.
Suggesting to use - DeferCleanup(func(cleanupCtx context.Context) in place of DeferCleanup(func(ctx context.Context)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.