-
Notifications
You must be signed in to change notification settings - Fork 28
customized automation of dep update #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TingDaoK
wants to merge
19
commits into
main
Choose a base branch
from
fix-actions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action is removed via #670 and reason can be found from the description.
We can make this better before we adapt it, but for now, it's not top priority.
LLM have successfully fixed the issue in the dependency-updates.yml file where the script was failing when packages don't have all the expected fields in the audit results. The specific problem you encountered with the jest-dev-server package has been resolved.
Root Cause Analysis
The script was failing with exit code 5 because:
fixAvailablefield was an object instead of a boolean: In the jest-dev-server case,fixAvailablewas{"name": "jest-puppeteer", "version": "11.0.0", "isSemVerMajor": true}instead of a simpletrue/falseviafield contained strings instead of objects: Theviaarray contained["wait-on"](strings) instead of objects withtitle,url, andcvssproperties.titleand.urlon strings, which caused jq to failFixes Applied
1. Fixed
fixAvailablehandling:Before:
FIX_AVAILABLE=$(jq -r ".vulnerabilities[\"$PACKAGE\"].fixAvailable // false" audit_results.json 2>/dev/null)After:
FIX_AVAILABLE=$(jq -r "if .vulnerabilities[\"$PACKAGE\"].fixAvailable then (if (.vulnerabilities[\"$PACKAGE\"].fixAvailable | type) == \"object\" then \"true\" else (.vulnerabilities[\"$PACKAGE\"].fixAvailable | tostring) end) else \"false\" end" audit_results.json 2>/dev/null)2. Fixed
viafield processing:Before: Always tried to access
.title,.url, and.cvss.scorepropertiesAfter: Added type checking to handle both cases:
title,url, andcvss.score3. Enhanced error handling:
All jq commands now use the
// "default_value"syntax to provide fallback values when fields are missing.Verification
I created comprehensive tests that verified the fixes work correctly with:
fixAvailableas object,viaas stringsfixAvailableas boolean,viaas objectsResult
The dependency-updates workflow will now:
fixAvailablevaluesviaarrays appropriatelyThe script is now robust against the variability in npm audit output formats and will no longer fail on packages like jest-dev-server that have non-standard field structures.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.