Skip to content

added .dvmrc version lock support#22

Open
Chathula wants to merge 1 commit intoaxetroy:masterfrom
Chathula:dvmrc-support
Open

added .dvmrc version lock support#22
Chathula wants to merge 1 commit intoaxetroy:masterfrom
Chathula:dvmrc-support

Conversation

@Chathula
Copy link
Copy Markdown

Story

This PR Incudes,

  • added .dvmrc file for deno version lock. this will automatically pick deno version from .dvmrc when run dvm use
  • updated the readme file with usage

@axetroy
Copy link
Copy Markdown
Owner

axetroy commented May 15, 2020

Thanks for your PR, but I do n’t think it ’s a good idea to add a .dvmrc

Keep it as simple as possible

@Chathula
Copy link
Copy Markdown
Author

Thanks for your PR, but I do n’t think it ’s a good idea to add a .dvmrc

Keep it as simple as possible

i think it is something important to have as nvm has it. this is something nodejs devs use daily to prevent from braking changes mainly. it will be important in the future when deno releases more breaking changes.

and most of the nodejs CIs use nvmrc when build the artifacts. deno will need it. just consider it again.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants