You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LGTM! Commands works fine now.
I was testing the just commit to run an initial commit and I noticed that pyproject-fmt and validate-pyproject where not in PATH so pre-commit fails. Running pdm add pyproject-fmt validate-pyproject seems to fix.
One last note, running just commit with the repo as it is after installing dependencies, will make ruff format fail because of missing docstrings inside the init.py of tests/ and src/. Kinda irrelevant imo, but maybe worth noticing.
That's something I missed, will add the two tools to the optional dependency groups. How do you find using pre-commit with tools inside your dev env? I followed @JeyDi's approach and went for that, rather than having pre-commit install the projects inside a separate venv on your system.
Actually it's not that bad: sometimes I've ran into weird issues where a command (black for example) would behave differently when ran locally vs remote pre-commit repo.
Furthermore, this should avoid running pre-commit autoupdate, as long as pdm dependencies are fixed correctly, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #4. @montanarograziano would you mind reviewing? 😊