fix #4341 固定ページのタイトル未入力時にプレビューで500エラーが発生する問題を修正#4350
Open
kaburk wants to merge 1 commit intobaserproject:5.2.xfrom
Open
fix #4341 固定ページのタイトル未入力時にプレビューで500エラーが発生する問題を修正#4350kaburk wants to merge 1 commit intobaserproject:5.2.xfrom
kaburk wants to merge 1 commit intobaserproject:5.2.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
固定ページの「タイトル未入力」状態で管理画面プレビューを実行した際に、プレビュー処理内のバリデーションエラー取り扱いが原因で例外が発生し、500 エラーになる問題（#4341）をテスト追加とサービス実装の調整で解消するPRです。
Changes:
- プレビュー処理（PagesFrontService）のバリデーションエラー検出時に例外を投げていた処理を削除
- 「タイトル未入力でもプレビューが 200 OK で返る」ことを確認するテストケースを追加
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/baser-core/tests/TestCase/Controller/Admin/PreviewControllerTest.php | タイトル未入力時のプレビューが正常応答することを回帰テストとして追加 |
| plugins/baser-core/src/Service/Front/PagesFrontService.php | プレビュー時のバリデーションエラーで例外送出していた処理を除去し、500 を回避 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします！