Termination

[matthiasbeyer]

Hi!

I rewrote the ExitCode type in this patchset, so not sure whether you like this. This would, of course, need a major version bump for this crate...

But it is necessary to implement std::process::Termination, which I would love to see, because that enables the user of this crate to return an ExitCode directly from main()!

Tell me what you think!

[matthiasbeyer]

I also emailed you because of maintainership of this crate, but the mail bounced. So maybe your mail setup is broken?

[SUPERCILEX]

A better solution would be to make these the stdlib exitcode: https://doc.rust-lang.org/stable/std/process/struct.ExitCode.html. That already implements termination.

Did you figure out a way to contact @benwilber? Maybe we can get the crate ownership transferred?

[SUPERCILEX]

Actually my thing is bad because then you lose access to the error code as a number (since std ExitCode is opaque). I found https://crates.io/crates/sysexits which is your PR but better because it's an enum.

[matthiasbeyer]

Did you figure out a way to contact @benwilber? Maybe we can get the crate ownership transferred?

No, I did not get any response from them. When meeting with the CLI WG yesterday we decided that there are other crates like this that are well maintained, for example sysexit but also proc-exit - so there's no need in getting access to this crate and we can consider it abandoned, I guess.

[SUPERCILEX]

Sounds good. Should https://rust-cli.github.io/book/in-depth/exit-code.html be updated then to recommend sysexit instead? I just migrated: SUPERCILEX/ftzz@8bb420f.

[SUPERCILEX]

Actually yeah, created rust-cli/book#177