Add the query_txid_plugin as a option #1954
Closed
bijianing97 wants to merge 5 commits intobitshares:developfrom
Closed
Add the query_txid_plugin as a option #1954bijianing97 wants to merge 5 commits intobitshares:developfrom
bijianing97 wants to merge 5 commits intobitshares:developfrom
Conversation
Contributor
|
Thanks for the numbers. 17% is significant but better than I'd have assumed. Can we close #1906 then? It looks broken now. |
Author
|
yes, you can close the #1906,i will rebase on the develp if there is no problem tomorrow |
This was referenced Aug 23, 2019
Contributor
|
Closing in favour of #1957 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.The pull request is the change to the #1906 ,set
query_txid_pluginas an option.You can compile the plugin by using
cmake -D LOAD_QUERY_TXID_PLUGIN=ONbeforemakeand if you don't want to use it ,justcmake ..2.I tested the impact of this plugin on replay speed.The number of the test blocks is 21000000.
Without the
query_txid_plugin:Total time :3:21:30
With the query_txid_plugin:
Total time : 3:55:30
Delayed by about 34 minutes