Signals for the external acquisition of an api_access_info#2051
Open
Dimfred wants to merge 1 commit intobitshares:developfrom
Open
Signals for the external acquisition of an api_access_info#2051Dimfred wants to merge 1 commit intobitshares:developfrom
Dimfred wants to merge 1 commit intobitshares:developfrom
Conversation
Contributor
|
I'm not really clear which problem you are trying to solve here. |
11 tasks
abitmore
reviewed
Aug 8, 2022
Member
abitmore
left a comment
There was a problem hiding this comment.
At the moment, I do think this is interesting. Unfortunately, the code is incomplete - no test cases or example code to show how to interact with it.
Author
|
Oh this was quite a while ago. If I find time I could look at what I even did there and maybe add tests / an example on how it could be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR I would like to introduce two new signals, to enable the api login process through an
external_service.Signal1:
application::login_attemptemitted at the end ofapplication_impl::new_connection.Signal2:
login_api::api_access_info_externalemitted at the beginning oflogin_api::login.Logic:
Alternatively this could be done with the first signal alone, but then the service would have to implement the login logic, which I tried to avoid here.
What do you think? Would this be a way to implement that? Open for any discussion.