Skip to content

Implicit integration#269

Draft
eiad-hamwi wants to merge 12 commits intobmad-sim:mainfrom
eiad-hamwi:implicit_2.0
Draft

Implicit integration#269
eiad-hamwi wants to merge 12 commits intobmad-sim:mainfrom
eiad-hamwi:implicit_2.0

Conversation

@eiad-hamwi
Copy link
Copy Markdown
Collaborator

@eiad-hamwi eiad-hamwi commented Mar 18, 2026

This PR contains an implementation for higher-orer, TPSA-compatible implicit integration, including a small test suite.

What's implemented and working:

  • 2nd, 4th, 6th, 8th order implicit spin-orbital with symplectic_step!
  • 2nd, 4th, 6th, 8th order implicit orbital TPSA with symplectic_step_tpsa!
  • Tests for solenoid and multipole maps

What's working and informally tested:

  • s-dependent fields (wiggler)

Still needs work:

  • Unpacking step for compatibility with Beamlines.jl
  • Electrostatic/electrodynamic fields
  • Tests for s-dependent fields
  • Implicit spin TPSA
  • Bend potential discrepancy

Note: TPSA compatibility could probably be more streamlined by using multiple dispatch on parametric types.

eiad-hamwi and others added 5 commits March 18, 2026 08:45
…A tracking, added tests. Dipole still disagrees with exact.
… for `symplectic_step!`, and tests. Solenoids will need fringe steps. Spin still needs TPS implementation
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 97.45763% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kernels/implicit.jl 97.01% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mattsignorelli mattsignorelli marked this pull request as draft March 20, 2026 10:45
@eiad-hamwi eiad-hamwi marked this pull request as ready for review March 20, 2026 15:21
@eiad-hamwi eiad-hamwi marked this pull request as draft March 20, 2026 15:22
@eiad-hamwi
Copy link
Copy Markdown
Collaborator Author

Test for bend vector potential is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant