Open
Conversation
Owner
There was a problem hiding this comment.
s3_domain to s3_url is a breaking change. The name may suck, but I'm stuck with it
Author
|
@branan - I tried to address all the concerns you had. I changed back the parameter name and got rid of the gem install by switching to a core ruby hmac-sha1 encoding method. |
Author
|
@branan any chance you will take this? |
|
Bump! Will this be merged? |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to be able to use the Authorization header for our OpenStack swift instance so i added some capabilities to this module. Let me know if there is anything you dislike or want cleaned up.