Unskip ReDoS test#293
Open
timostamm wants to merge 1 commit intojonbodner/add_re2from
Open
Conversation
jonbodner-buf
left a comment
jonbodner-buf
left a comment
There was a problem hiding this comment.
One question about PR ordering.
| void suite("logic", () => { | ||
| void suite("matches(string, string) -> bool", () => { | ||
| void test.skip("doesn't evaluate simple ReDoS expressions in exponential time", () => { | ||
| void test("doesn't evaluate simple ReDoS expressions in exponential time", () => { |
There was a problem hiding this comment.
Should we merge this before the re2js merge?
There was a problem hiding this comment.
apparently not, it depends on @bufbuild/re2
Member
Author
There was a problem hiding this comment.
The test is a guard against ReDoS. It fails with the current implementation on main, and I expect it to pass in your branch.
It's currently skipped on main because it fails on main. We could merge this change into main, but it means CI would be red, and we'd be stuck if some other work comes along before we can merge your branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.