Conversation
This reverts commit 210daff.
solatis
requested changes
Mar 17, 2026
Contributor
solatis
left a comment
solatis
left a comment
There was a problem hiding this comment.
Feedback regarding where to place validation functions -- I think you put them in the wrong place, in the "convert between qdb-api C-types and C++ representations", which should not be rejecting things like this. The validations should be put right before/after the conversion happened, probably after.
These conversion functions should definitely not silently skip $timestamp columns etc, that's not the correct place.
solatis
approved these changes
Mar 17, 2026
vikonix
deleted the
sc-18665/-python-make-a-column-timestamp-mandatory-for
branch
vikonix
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.