Fix baseWidth fallback cascade in export width measurement#17
Merged
Fix baseWidth fallback cascade in export width measurement#17
Conversation
Co-authored-by: byemaxx <44231502+byemaxx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix matrix layout and export cropping based on feedback
Fix baseWidth fallback cascade in export width measurement
Jan 7, 2026
byemaxx
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #16 regarding flawed fallback logic that prevented
rect.widthfrom being evaluated when intrinsic width measurements failed.Problem
The existing fallback logic applied the minimum value too early, making the conditional check unreachable:
Since
Math.max(..., 1)guaranteesbaseWidth >= 1, the condition!baseWidthis never true, andrect.widthis never checked.Solution
Restructured to cascade through measurements before applying the minimum:
This ensures all available width sources are evaluated before defaulting to the hardcoded minimum.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.