Open
Conversation
Preview deployments |
Contributor
|
Dono what the motivation of this work is. I understand we had issues that everything was AppListing. But, now you are removing all the different listing types which makes me confused |
Contributor
Author
I reverted the code. Now we just eliminate AppListing checking during the listing creation process. |
lucaslyl
changed the title
…ardlisting-except-fieldlisting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linear: https://linear.app/cardstack/issue/CS-10435/default-every-listing-creation-to-cardlisting-except-fieldlisting
Remove app listing type guessing from ListingCreateCommand. Users can manually change the listing type from cardListing to AppListing after creation.