Merged
Conversation
The background-action only waited for host (localhost:4200) but ci:serve-test-assets starts both host and icons. Wait for both to prevent Playwright tests from starting before icons are ready. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Same fix as software-factory-test: wait for both host and icons before proceeding with integration tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test-services:matrix task is backgrounded, so the workflow doesn't block on its internal start-server-and-test readiness checks. Use background-action with wait-on for both host and icons to prevent Playwright tests from starting before services are ready. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
If both icons and host are already reachable, skip start-server-and-test entirely and just block. This prevents start-server-and-test from failing when run-p exits immediately because both start:icons and start:host-dist detect existing servers and exit 0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ui-cs-10531 # Conflicts: # .github/workflows/build-host.yml # .github/workflows/ci.yaml # .github/workflows/deploy-ui.yml # .github/workflows/manual-vscode-boxel-tools.yml # .github/workflows/test-web-assets.yaml # mise-tasks/build/ui
backspace
changed the title
boxel-icons
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c7a69fc0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jurgenwerk
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses Actions caching to skip building
boxel-iconswhen it hasn’t changed, which isalmost always. The performance of
Build test web assetsjob has averaged 3m23s inMarch, with the icon-building usually taking a minute in these precursor jobs:
When there’s an icons cache hit in this branch, we save much of that, with the jobs for this PR having averaged 2m29s: