Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c41fe5b3ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let visitPromise = visit('/test/Pet/non-existent.json'); | ||
| await waitFor('[data-test-host-loading]'); | ||
| assert.dom('[data-test-host-loading]').exists(); | ||
| assert | ||
| .dom('[data-test-host-loading]') | ||
| .doesNotExist('Loading screen is never shown on host mode'); | ||
| gate.fulfill(); |
There was a problem hiding this comment.
This assertion now runs immediately after visit('/test/Pet/non-existent.json'), but the route may not yet have reached the gated store.get call, so gate.fulfill() can fire before any real loading state is exercised. In that case the test can pass even if a loading screen appears briefly under actual network delay, which weakens the regression coverage this test is meant to provide; synchronize on a deterministic "request is pending" signal before checking doesNotExist.
Useful? React with 👍 / 👎.
Preview deployments |
1 participant
No description provided.