Skip to content

fix: apply window insets to all settings activities for edge-to-edge support#260

Merged
a1denvalu3 merged 1 commit intomainfrom
fix/edge-to-edge-settings
Apr 13, 2026
Merged

fix: apply window insets to all settings activities for edge-to-edge support#260
a1denvalu3 merged 1 commit intomainfrom
fix/edge-to-edge-settings

Conversation

@a1denvalu3
Copy link
Copy Markdown
Collaborator

Summary

  • Applied ViewCompat.setOnApplyWindowInsetsListener to properly handle system window padding across all screens reachable from the settings menu.
  • Fixes layout overlap with system bars caused by edge-to-edge enforcement on Android 15 (target SDK 35).
  • Replicated the proven fix from PaymentRequestActivity (PR fix: handle edge-to-edge UI in PaymentRequestActivity #258) across the remaining affected activities.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 2.94118% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.56%. Comparing base (22b7b9f) to head (ba1069a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...umo/feature/baskets/BasketNamesSettingsActivity.kt 0.00% 4 Missing ⚠️
...ctricdreams/numo/feature/items/ItemListActivity.kt 0.00% 4 Missing ⚠️
...lectricdreams/numo/feature/pin/PinEntryActivity.kt 0.00% 4 Missing ⚠️
...ctricdreams/numo/feature/settings/AboutActivity.kt 0.00% 4 Missing ⚠️
.../numo/feature/settings/CurrencySettingsActivity.kt 0.00% 4 Missing ⚠️
...numo/feature/settings/DeveloperSettingsActivity.kt 0.00% 4 Missing ⚠️
...cdreams/numo/feature/settings/ErrorLogsActivity.kt 0.00% 4 Missing ⚠️
.../numo/feature/settings/LanguageSettingsActivity.kt 0.00% 4 Missing ⚠️
...ams/numo/feature/settings/MintsSettingsActivity.kt 0.00% 4 Missing ⚠️
.../numo/feature/settings/SecuritySettingsActivity.kt 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #260      +/-   ##
============================================
- Coverage     20.64%   20.56%   -0.08%     
+ Complexity      773      771       -2     
============================================
  Files           145      145              
  Lines         18575    18643      +68     
  Branches       2274     2274              
============================================
  Hits           3834     3834              
- Misses        14261    14326      +65     
- Partials        480      483       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1denvalu3 a1denvalu3 merged commit cce812a into main Apr 13, 2026
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Numo Apr 13, 2026
@a1denvalu3 a1denvalu3 deleted the fix/edge-to-edge-settings branch April 13, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant