fix nut-29 test vector, clarify concatenation rules.#362
Open
robwoodgate wants to merge 1 commit intocashubtc:mainfrom
Open
fix nut-29 test vector, clarify concatenation rules.#362robwoodgate wants to merge 1 commit intocashubtc:mainfrom
robwoodgate wants to merge 1 commit intocashubtc:mainfrom
Conversation
… for nut-20 signing
Collaborator
Do they already use these test vectors then or we need to add them probably? |
Contributor
Author
Cashu-ts uses the specific NUT-29 vector (how I found out it was wrong), cdk uses other tests, but not that vector specifically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NUT-29 test vector was not correctly using NUT-20 message-to-sign rules.
This PR fixes the test vector, clarifies the rules, and adds the intermediate steps for verification (eg message hash)
Note for reviewers:
I confirmed that cashu-ts and cdk both were doing NUT-29 message aggregation correctly. It was only the test vector which was incorrect.