feat(mint): remove deprecated v0 HTTP API#957
Open
b-l-u-e wants to merge 1 commit intocashubtc:mainfrom
Open
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Author
|
CI failed tests shows error current workspace file ends at line 767 and has no line 779 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is what was done for #953 - remove deprecated mint v0 API:
Removed
cashu/mint/router_deprecated.py- root-level routes (/info,/keys,/mint,/melt,/split,/check,/restore, etc.) that duplicated the old pre-v1 surface.tests/mint/test_mint_api_deprecated.py- already fully skipped; removed.tests/fuzz/test_fuzz_mint_api_deprecated.py- fuzzing only the removed routes; removed.Mint app
cashu/mint/app.py- mounts only the v1router(no deprecated router). The file on disk already matched this after the edits.Settings
debug_mint_only_deprecatedremoved fromcashu/core/settings.py. It only toggled “deprecated-only” vs “v1 + deprecated”; with v0 gone it has no use.Tests & helpers
tests/helpers.py- droppedis_deprecated_api_only.debug_mint_only_deprecated/is_deprecated_api_onlywere simplified (always exercise v1 behavior, or drop obsoleteskipif/pytest.skip).tests/mint/test_mint_melt.py- skip reason is now “only FakeWallet”; condition isnot is_fakeonly.CI / docs
.github/workflows/tests.yml,ci.yml,tests_redis_cache.yml- removedmint-only-deprecatedinput, matrix dimension, andDEBUG_MINT_ONLY_DEPRECATEDenv.CONTRIBUTING.md- removed the “V0 API only” /DEBUG_MINT_ONLY_DEPRECATEDsubsection.Not removed
*_deprecatedmodels incashu/core/models.pyandPostMeltResponse_deprecatedusage incashu/wallet/v1_api.pystay for interoperability with older mint JSON, not for serving the removed routes.