Conversation
auvipy
left a comment
There was a problem hiding this comment.
REALLY TOUGH TO REVIEW SUCH LARGE DIFF!!
|
Yes, the examples directory should be ignored when reviewing this. |
|
Seems like we have a genuine problem with strings inside dictionaries on Python 2. |
|
Since Not sure how to resolve this issue. |
|
Authentication fails with the addition of support for small strings in tables and arrays. Also, tox-docker doesn't seem to work anymore which is super strange. |
|
Seems like there's a bug in RabbitMQ with short strings in tables. |
|
I found the source of the problem: |
auvipy
left a comment
There was a problem hiding this comment.
IMHO te existing example based tests should stay on place. we should use property based testing as a complete different suite.
This PR uses hypothesis to check if arrays & dictionaries are serialized and deserialized correctly.
I also fixed our integer serialization and deserialization code, bytes string serialization and small string serialization on tables and arrays.