fix: use thinking levels for Gemini 3 models#3609
fix: use thinking levels for Gemini 3 models#3609MashiroCodfish wants to merge 2 commits intochatboxai:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ec8c8b1 to
787782f
Compare
|
Nice work overall — the budget vs level split for Gemini 2.5/3 is the right call. Two issues worth addressing: 1. UI shows a default thinking level that is never sent to the API In Result: UI says "High", but the actual API call uses the model's server-side default (which may differ). Fix: write the fallback level into 2. Stale
Fix: in the |
|
Thanks, fixed both points in the latest push ( Changes:
Re-tested with:
|
|
Thanks for the contribution! The core idea of splitting Gemini 3 thinking levels from Gemini 2.5 thinking budgets is exactly right. After reviewing this PR, we found a few issues we'd like to address:
We've already implemented a fix internally that addresses all of the above. The main design difference is that instead of writing back defaults via useEffect (which breaks Reset), we fill in the default level inside I plan to land our version directly. Would you mind if we close this PR? Happy to credit you in the commit message for identifying the original issue and the overall approach. Thanks again for the effort! |
|
Thanks for the detailed review and for implementing the follow-up fix on your side. Please feel free to close this PR. And yes, I'd appreciate the credit in the commit message — thanks again for taking this forward. |
Summary
Notes
flashheuristicsTesting
Closes #3542