ensure if the open file have the good link.#1153
Open
rednaks wants to merge 1 commit intocircus-tent:masterfrom
Open
ensure if the open file have the good link.#1153rednaks wants to merge 1 commit intocircus-tent:masterfrom
rednaks wants to merge 1 commit intocircus-tent:masterfrom
Conversation
Author
|
it seems that fstat is failing on mac platform any ideas for an alternative api ? |
k4nar
reviewed
Dec 14, 2020
Contributor
k4nar
left a comment
k4nar
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Do you think we could use os.path.exists instead?
Also a unit test for this would be awesome 🙏 .
Contributor
|
I commented on the original issue with an example of a working setup with logrotate, please check it out. Therefore I think we might not need this change at all. |
Author
|
@k4nar not really because logrotate create a new file the issue is not the existance or not of the file but the link between the open file and the existing file on the disk @biozz sorry I forgot to reply your comment on the issue, I actually tried it and it doesn't work, it's less frequent but still have the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing #1152