This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Make config handle proxies of android.* classses#70
Open
satchit8 wants to merge 2 commits intoclojure-android:masterfrom
Open
Make config handle proxies of android.* classses#70satchit8 wants to merge 2 commits intoclojure-android:masterfrom
satchit8 wants to merge 2 commits intoclojure-android:masterfrom
Conversation
Author
|
After reading more of the existing tests, I see that using multiple let blocks within a single deftest seems to be preferred. So may be the following is more appropraite: (deftest config
(let [v (ui/make-ui RuntimeEnvironment/application [:button {:text "hello"}])]
(is (= View/VISIBLE (.getVisibility v)))
(is (= "hello" (.getText v)))
(ui/config v :text "updated" :visibility View/GONE)
(is (= "updated" (.getText v)))
(is (= View/GONE (.getVisibility v))))
(let [ll (ui/make-ui RuntimeEnvironment/application
[:linear-layout {:custom-constructor
(fn [ctx]
(proxy [LinearLayout] [ctx]))
:orientation :vertical}])]
(is (= LinearLayout/VERTICAL(.getOrientation ll)))
(ui/config ll :orientation :horizontal)
(is (= LinearLayout/HORIZONTAL (.getOrientation ll))))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found another use of keyword-by-classname, so here are similar modifications as with #68.