Add first-class Windows support#8
Merged
chaploud merged 5 commits intoclojurewasm:mainfrom Mar 15, 2026
Merged
Conversation
… docs - run_compat.py: use --dir /tmp on Mac/Linux (guest path alias only on Windows) — fixes rust_file_io FAIL regression - wasi.zig path_filestat_get: restore fstatat + SYMLINK_NOFOLLOW on POSIX; add writeFilestatPosix preserving nlink/mode from Stat - wasi.zig fd_close: add comment explaining stdio SUCCESS (wasmtime compat) - wasi.zig writeFilestat: document nlink=1 limitation - README.md: fix duplicate Stage 33 (fuzz=33, windows=34), remove "Windows port" from Future - run_spec.py: detect .exe on Windows for ZWASM path
- guard.zig: replace magic -1 with named EXCEPTION_CONTINUE_EXECUTION - wasi.zig: simplify HostHandle.close() — remove unnecessary mutable copy for File (File.close takes self by value, Dir needs *Dir) - wasi.zig: document fd_renumber placeholder entries as never-accessed - wasi.zig: add doc comment on allocFd ordering constraint
- embedding.md: add .dll/.lib to lib output, cross-platform ctypes - security.md: add Windows x86_64 to spec test platform list - roadmap.md: mark Phase 15 (Windows) done, add v1.6.0 milestone - decisions.md: add D129 (Windows first-class support architecture) - memo.md: update current state and task for PR clojurewasm#8 review
- record.sh/run_bench.sh: replace declare -A (bash 4+) with file-based storage and string matching for bash 3 compat - Record 58 benchmarks (29 uncached + 29 cached) for PR clojurewasm#8
Contributor
|
Thanks again @DeanoC — another great contribution! Windows (x86_64) first-class support is a big milestone for zwasm. I reviewed the full diff (26 files), ran the merge gate on macOS + Ubuntu locally, and pushed a few follow-up commits on top:
CI is all green across macOS, Ubuntu, and Windows. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Notes