Skip to content

Add a container inspect API to read labels#6631

Open
gpanders wants to merge 1 commit intomainfrom
ganders/xquymsrukwml
Open

Add a container inspect API to read labels#6631
gpanders wants to merge 1 commit intomainfrom
ganders/xquymsrukwml

Conversation

@gpanders
Copy link
Copy Markdown
Member

There is currently no way to read the labels set in a container. Add a new inspect API that returns the labels set on a container.

In the future, this can be extended to also provide other information (like entrypoint or env).

@gpanders gpanders requested review from a team as code owners April 21, 2026 20:19
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 21, 2026

@gpanders Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@gpanders gpanders force-pushed the ganders/xquymsrukwml branch from 756739a to 2d77c90 Compare April 21, 2026 20:21
@gpanders gpanders requested a review from a team as a code owner April 21, 2026 20:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@gpanders gpanders force-pushed the ganders/xquymsrukwml branch from 2d77c90 to b23ebf8 Compare April 21, 2026 20:34
Comment thread src/workerd/api/container.h Outdated
@petebacondarwin petebacondarwin self-requested a review April 22, 2026 06:36
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the type snapshots need fixing

@gpanders gpanders force-pushed the ganders/xquymsrukwml branch from b23ebf8 to 58c6dc8 Compare April 22, 2026 17:24
@gpanders
Copy link
Copy Markdown
Member Author

Moved this under the experimental flag and addressed some feedback from a local AI reviewer.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.41%. Comparing base (b71cfd7) to head (f12203a).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/server/container-client.c++ 0.00% 40 Missing ⚠️
src/workerd/api/container.c++ 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6631      +/-   ##
==========================================
- Coverage   66.51%   66.41%   -0.10%     
==========================================
  Files         405      405              
  Lines      115815   116154     +339     
  Branches    19381    19439      +58     
==========================================
+ Hits        77032    77142     +110     
- Misses      27208    27431     +223     
- Partials    11575    11581       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gpanders gpanders force-pushed the ganders/xquymsrukwml branch from 58c6dc8 to be5a4b4 Compare April 23, 2026 13:42
Comment thread src/workerd/api/container.c++ Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing ganders/xquymsrukwml (f12203a) with main (b322726)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

There is currently no way to read the labels set in a container. Add a
new `inspect` API that returns the labels set on a container.

In the future, this can be extended to also provide other information
(like `entrypoint` or `env`).
@gpanders gpanders force-pushed the ganders/xquymsrukwml branch from be5a4b4 to f12203a Compare April 23, 2026 14:56
@gpanders
Copy link
Copy Markdown
Member Author

Looks like the type snapshots need fixing

Fixed now, can you please re-review @petebacondarwin ?

Comment thread src/workerd/server/container-client.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants