Fix stale import attributes description in module registry docs#6664
Open
rocketman-code wants to merge 1 commit intocloudflare:mainfrom
Open
Fix stale import attributes description in module registry docs#6664rocketman-code wants to merge 1 commit intocloudflare:mainfrom
rocketman-code wants to merge 1 commit intocloudflare:mainfrom
Conversation
The Dynamic Import Flow section stated import attributes are rejected
("not yet supported"), but PR cloudflare#6423 added parseImportAttributes support
for type: 'json'. The Evaluation Invariants section in the same document
already describes the correct behavior. Update the flow to match.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dynamic Import Flow section in new-module-registry.md says import attributes are rejected ("not yet supported"), but #6423 added
parseImportAttributessupport fortype: 'json'. The Evaluation Invariants section in the same document already describes the correct behavior. This updates the flow to match.