Skip to content

Conversation

@johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 7, 2025

No description provided.

@johnstcn johnstcn requested a review from mafredri November 7, 2025 15:23
@johnstcn johnstcn self-assigned this Nov 7, 2025
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions but LGTM

- Starts a Coder Task using your specified template and preset
- Posts a single status comment on a GitHub issue
- Maps GitHub users to Coder users
- When creating a Coder task, you must specify the Github user ID as an input.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- When creating a Coder task, you must specify the Github user ID as an input.
- When creating a Coder task, you must specify the Github username as an input.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We store the GitHub user ID in the users table and lookup based on that, not the username.

- Posts a single status comment on a GitHub issue
- Maps GitHub users to Coder users
- When creating a Coder task, you must specify the Github user ID as an input.
- The action then queries the Coder deployment to find the Coder user associated with the given Github user ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.md Outdated
| coder-url | Coder deployment URL | true | - |
| coder-organization | Coder organization name | true | - |
| coder-task-name-prefix | Prefix for task name | true | - |
| coder-template-name | Coder template to use for workspace | true | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC our cli makes this optional if there only exists one task template. Open to leaving it required though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explicit is better than implicit in this particular use-case.

README.md Outdated
| github-issue-url | GitHub issue URL to link this task to | true | - |
| github-token | GitHub token for API operations | true | - |
| github-user-id | GitHub user ID to create task for | true | - |
| coder-template-preset | Template preset to use (optional) | false | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about template version id, expose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might leave that until requested.

@johnstcn johnstcn merged commit e9676de into main Nov 10, 2025
1 check passed
@johnstcn johnstcn deleted the cj/update-readme branch November 10, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants