Open
Conversation
🟡 Heimdall Review Status
|
40472cf to
d4a1e25
Compare
4c83272 to
9e61361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
nest_asynciodependency.nest_asynciois unmaintained and breaks on Python 3.12+ (loop_factoryparameter mismatch)._EvmServerAccountSync, a private class backingEvmLocalAccountthat calls the three CDP signing endpoints synchronously via the existingUrllib3AuthClient. No new dependenciesnest-asynciofrompyproject.tomland regenerates lock files forpython/andexamples/python/Why not a sync-to-async bridge?
The thread-based approaches (e.g.
run_coroutine_threadsafe,ThreadPoolExecutor) are patches that create new problems. The fundamental design tension would remain. The real fix is a native sync HTTP path for the subset of operationsEvmLocalAccountneeds.Why not generate a second OpenAPI client?
Only 3 endpoints are needed (
sign,sign/message,sign/transaction). A full generated sync client would duplicate ~250 files for no benefit._EvmServerAccountSyncis ~80 lines and entirely self-contained.Closes #591.
Tests
Ran the example
examples/python/evm/ecosystem/web3py/evm_local_account.py:Checklist
A couple of things to include in your PR for completeness: