refactor: use v2 delegated routing for end user operations#659
Merged
refactor: use v2 delegated routing for end user operations#659
Conversation
✅ Heimdall Review Status
|
Contributor
|
f5f138b to
bf364f8
Compare
sddioulde
approved these changes
Apr 16, 2026
|
Review Error for sddioulde @ 2026-04-16 22:02:08 UTC |
de79eab to
ebb775d
Compare
sddioulde
approved these changes
Apr 16, 2026
marcin-cb
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the TypeScript SDK's end user delegated signing operations to use v2 delegated routing.
Key changes:
projectIdrequirement: Delegated signing/sending operations no longer require a separateprojectIdparameter. Removed fromCdpClientOptions,EndUserClientconstructor,ToEndUserAccountOptions, and all API call sites.CDPEndUserClienttoEndUserClient: Simplified class naming for consistency.openapi.yamland regenerated TypeScript OpenAPI client code. Theembedded-walletsmodule replaces the oldembedded-wallets-delegated-signing/embedded-wallets-core-functionalitymodules.endUser.test.tsandcdpApiClient.test.tsthat were tied to the old routing.@coinbase/cdp-sdk.Tests
The delegated signing operations (signEvmHash, signEvmTransaction, signEvmMessage, signEvmTypedData, sendEvmTransaction, sendEvmAsset, sendUserOperation, createEvmEip7702Delegation, revokeDelegation) were updated to use the v2 API routes which no longer require
projectIdas a path parameter.Checklist