fixed typos in best-practices.md#315
Open
bamiwoaluko wants to merge 1 commit intocommon-workflow-language:mainfrom
Open
fixed typos in best-practices.md#315bamiwoaluko wants to merge 1 commit intocommon-workflow-language:mainfrom
bamiwoaluko wants to merge 1 commit intocommon-workflow-language:mainfrom
Conversation
kinow
reviewed
Oct 18, 2022
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
The last change sounds a bit off to me. Leaving that to a native speaker to review 👍
tetron
suggested changes
Oct 24, 2022
Member
tetron
left a comment
tetron
left a comment
There was a problem hiding this comment.
This is not a typo, this was written that way an purpose. "A CWL document is code" is grammatically correct. "Dockerfiles" is plural because "components" is plural. Possibly this sentence could be rewritten to be clearer, otherwise the PR should be closed without merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.