Add PR workflow, Gradle wrapper, and simplify podspec#5
Conversation
…ade esbuild dependencies in package-lock.json to version 0.25.12 for compatibility.
… xcframework, removing the need for GitHub credentials. Add iOS validation steps to the pull request workflow to ensure podspec syntax and source file existence.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's build and continuous integration processes. It introduces automated checks for code quality and platform-specific builds, streamlines the iOS dependency management by removing a credential requirement, and updates core development dependencies. These changes aim to improve developer experience, ensure code stability, and simplify future maintenance. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR sets up CI infrastructure for pull requests and simplifies the Android and iOS native dependencies by removing the need for private GitHub Packages authentication. It adds a GitHub Actions workflow to validate TypeScript, tests, npm packaging, Android build configuration, and iOS podspec on every PR to main.
Changes:
- Added GitHub Actions PR workflow with four jobs: type check & tests, package validation, Android build validation, and iOS podspec validation
- Added Gradle wrapper (
gradlew,gradlew.bat,gradle-wrapper.jar,gradle-wrapper.properties) to theandroid/directory for CI use - Simplified
ConektaElements.podspecto use a hardcoded download URL with SHA-256 checksum, removing the~/.netrcrequirement; updated Android dependency toio.conekta:conekta-elements-compose:0.0.2-beta.2and removed private Maven registry
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pull-request.yml |
New CI workflow for PRs; adds Android and iOS validation jobs |
ConektaElements.podspec |
Replaces authenticated GitHub API download with direct public URL + checksum |
android/build.gradle |
Removes private Maven registry, updates Conekta Compose dependency version |
android/gradlew |
Standard Gradle wrapper shell script for POSIX environments |
android/gradlew.bat |
Standard Gradle wrapper batch script for Windows |
android/gradle/wrapper/gradle-wrapper.properties |
Gradle 8.2 distribution configuration |
android/gradle/wrapper/gradle-wrapper.jar |
Binary Gradle wrapper bootstrap JAR |
package-lock.json |
Vite downgraded from 7.x to 6.x and esbuild from 0.27.x to 0.25.x (both compatible with vitest 4.x) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request introduces a GitHub Actions workflow for CI, adds the Gradle wrapper for consistent Android builds, and simplifies the iOS podspec by using a direct download URL. However, a critical vulnerability exists in the podspec where the checksum verification does not stop execution upon failure, which could lead to the use of an unverified or malicious framework. Additionally, my review includes suggestions to improve maintainability by extracting hardcoded dependency versions into variables in both the podspec and build.gradle files, and a question about a potential unintentional downgrade of vite and esbuild dependencies in package-lock.json. Positive security changes include the removal of hardcoded credentials from android/build.gradle.
…eta.2 for improved functionality.
…ConektaElements.podspec and refining iOS source file validation. Update build.gradle to use a variable for Conekta Elements version for better maintainability.
…um from package.json, enhancing maintainability. Modify build.gradle to use the dynamic version for Conekta Elements dependency. Add validation steps in the pull request workflow to ensure version consistency and configuration integrity.
…oved compatibility. Refactor verification step for ConektaElements config in package.json for clarity.
…fy installation instructions for `.npmrc` and enhance usage section with example app scripts.
Summary
android/for CI build validationConektaElements.podspecto use a direct download URL with checksum verification (no more~/.netrcrequired)0.0.2-beta.2Test plan
maintsc --noEmitandvitestpass in CInpm pack --dry-runsucceeds./gradlew taskspasspod installworks without~/.netrccredentials🤖 Generated with Claude Code