Fix FSEventStreamScheduleWithRunLoop deprecation warning on macOS 13+#1
Open
ndbroadbent wants to merge 1 commit intoconvox:masterfrom
Open
Fix FSEventStreamScheduleWithRunLoop deprecation warning on macOS 13+#1ndbroadbent wants to merge 1 commit intoconvox:masterfrom
ndbroadbent wants to merge 1 commit intoconvox:masterfrom
Conversation
Replace the deprecated FSEventStreamScheduleWithRunLoop API with the modern FSEventStreamSetDispatchQueue API that uses Grand Central Dispatch. This eliminates the deprecation warning while maintaining the same functionality for file system event monitoring on macOS.
Author
|
@nightfury1204 I was wondering if you could please take a look at this? thanks! |
|
Thanks for the pr.It would be better if we can deprecate this library and replace it with actively managed library. |
Author
|
Hey sure I totally agree! I was just wanting to get rid of the deprecation warnings but either way is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated FSEventStreamScheduleWithRunLoop API with the modern FSEventStreamSetDispatchQueue API that uses Grand Central Dispatch.
This eliminates the deprecation warning while maintaining the same functionality for file system event monitoring on macOS, e.g. when running tests in convox/convox: