fix(core): use separate buffer for span close events#271
Open
CrabNejonas wants to merge 3 commits intomainfrom
Open
fix(core): use separate buffer for span close events#271CrabNejonas wants to merge 3 commits intomainfrom
CrabNejonas wants to merge 3 commits intomainfrom
Conversation
This changes the span events buffering to put close events into a separate buffer. This is important because close events are used for animations and calculations in the frontend, completely missing out on them leads to incorrectness.
CrabNejonas
requested review from
david-crabnebula and
lucasfernog-crabnebula
as code owners
✅ Deploy Preview for cn-devtools-app canceled.
|
Contributor
|
I tested this and this does improve droppage of close events. But I feel like we should not only focus on them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the span events buffering to put close events into a separate buffer. This is important because close events are used for animations and calculations in the frontend, completely missing out on them leads to incorrectness.